Closed gotreasa closed 7 months ago
Nice work @gotreasa
I'm new to Graphite, I assume I shouldn't need to login to view your link, but I am being forced to. Is there any additional context in there, not shown in your PR description, or via the commit titles?
Graphite states from their docs
Use Graphite even if your teammates don't yet. Graphite seamlessly integrates with GitHub so you can securely collaborate with team members who haven't made the switch.
I'm all in favour of these types of atomic commits within a PR and highly appreciate it along with following the commit conventions, and really appreciate each of the various updates and fix ups. Extra kudos for updating the CLI .
For bonus points you could update the CLI to support arm64 for linux and macos in the makefile.
@YOU54F thanks for reviewing the changes. Graphite splits the code into PRs which can be accessed as normal with Github: chore: remove unused packages and upgrade vulnerabilities ci: update the build and pipeline files to handle the latest version of all tooling docs: update the README file based on the changes for Cypress and fixing typos feat: setup husky and lint-staged feat: install typesync and sync types chore: update eslint version to 8.56.0 chore: update start-server-and-test to version 2.0.2 feat: update cypress to version 13.6.6 feat: update react to version 18.2.0 and format with ESLint chore: update axios version to 1.6.7 chore: update ESLint ECMA version to 2023 fix: update the Makefile so that that install command can execute
This way you don't need to log in with Github to Graphite.
That's a great suggestion for the Makefile. I was focused on getting it to work with the pipeline, I didn't think of getting it to work with arm64 for the developer's local development environment. I'll give that try to detect the architecture to use for the ruby installation.
I've made the changes to the Makefile to default the Ruby version to 2.4.1 and detect the architecture.
Thanks again for this great contribution @gotreasa - we really appreciate it!
If you want, I can send you out a couple of Pact stickers?
Full details of each change and what they do are in https://app.graphite.dev/github/pr/gotreasa/example-bi-directional-consumer-cypress/23.
Graphite has been used to isolate each change to make the review a lot easier. There are 12 PRs stacked on top of each other. The philosophy is to create PR on top of the previous PR. So it starts off from main. If a change needs to be made, it can be, and then synced, or if part of the stack needs to be merged it can be. The goal is to make it easier to review the changes.