search

pactflow / swagger-mock-validator

Other
14 stars 5 forks source link

feat: upgrade packages and move to ESM-only dist #24

Closed vwong closed 1 year ago

vwong commented 1 year ago

More and more modules are moving to ESM-only, including some packages that we depend on. This is a trend that is only going to accelerate. We were previously creating CommonJS output that couldn't handle such ESM-only dependencies. Ie, we couldn't synchronously require it. As such, to keep up with the latest packages, we need to change the way we consume our dependencies and create our outputs.

As such, I'm introducing Rollup as a bundler to handle not only the transpilation of Typescript, but also the mismatch between the module types. You will notice as part of this change, we're removing some strange looking code like import * as fs from "fs", replacing it with the saner import fs from "fs".

Further, for running tests locally using Jasmine, there is no longer a separate build-output as the Typescript transpilation is part of the test runner now. This has the added benefit of giving us more accurate source code line numbers for debugging.

BREAKING: This increase the Node requirements to Node 14, and requires consumers of this package to be able to handle ESM-only packages

YOU54F commented 1 year ago

sounds sensible to me, we can drop node 14 support as it has just eold and test against 16,18 and 20

mefellows commented 1 year ago

BREAKING: This increase the Node requirements to Node 14, and requires consumers of this package to be able to handle ESM-only packages

This is acceptable to me. We can also release a new major version.