pactflow / swagger-mock-validator

Other
14 stars 4 forks source link

chore: update docs to make release process clearer #5

Closed Inksprout closed 2 years ago

Inksprout commented 2 years ago
Inksprout commented 2 years ago

Side note: builds won't pass because only markdown files have changed it seems like

YOU54F commented 2 years ago

Hey @Inksprout think you just need a space between chore: description

this is the commit it runs if you want to check the error locally, pre push git hook would be nice so we could amend beforehand but future dreams

./node_modules/.bin/conventional-changelog-lint --from=HEAD~20 --preset angular

YOU54F commented 2 years ago

Yes that is correct, great update thanks. I realised the slug pattern was diff because in some repos I had a https remote rather than an ssh remote, so the git remote command returns a diff value, would be nice to detect that in the script as it took me a while to grok

YOU54F commented 2 years ago

I tried to diverge as little as possible away from the original fork, but happy to move this more in line with a standardised build pattern in the future

Inksprout commented 2 years ago

I tried to diverge as little as possible away from the original fork, but happy to move this more in line with a standardised build pattern in the future

yeah I think gradual change is good in this case

Inksprout commented 2 years ago

Yes that is correct, great update thanks. I realised the slug pattern was diff because in some repos I had a https remote rather than an ssh remote, so the git remote command returns a diff value, would be nice to detect that in the script as it took me a while to grok

AHH ok, that makes sense, I couldn't work out what the existing script was trying to do at all :') yeah I guess we will have to adapt the script to detect that somehow