pactflow / terraform-provider-pact

Terraform provider for Pact Broker (and Pactflow)
https://pactflow.io
MIT License
24 stars 4 forks source link

fix: exclude team administrator role from User resource #22

Closed mefellows closed 2 years ago

mefellows commented 2 years ago

You can’t directly assign the TeamAdministrator role, because it’s one of those special uuid scoped ones. This means you can't add it to the User resource as it will have no effect, but will result in Terraform thinking it needs to apply a diff.

The ability to assign one or more Administrators to a Team has been added to resolve this.

The issue with this, is that terraform will read the remote resource and see the additional role(s) and report that it will try to remove them - so end users need to add the team administrator role (d635f960-88f2-4f13-8043-4641a02dffa0) to the User resource (despite it having no effect) because it will come back in the API read and look like somebody has modified the remote state.

The proposal here is to always remove/filter out the team administrator role for read operations

See also https://pact-foundation.slack.com/archives/C02NN7XSHDM/p1649732110486579?thread_ts=1649386851.603279&cid=C02NN7XSHDM

mefellows commented 2 years ago

Fixed in 376e92f and released in 0.0.8.