search

pacu / zwcd

Zcash Wallet Community Developer tasks
MIT License
2 stars 0 forks source link

Review Migration Path PR for Nighthawk Wallet #17

Closed pacu closed 10 months ago

pacu commented 10 months ago

Review the PR that migrates legacy wallet users to the new wallet code https://github.com/nighthawk-apps/nighthawk-ios-wallet/pull/7#event-10086229444

pacu commented 10 months ago

I reviewed and spotted a few things. Also recommended the devs to let the users back up their keys before migrating.

Also did a change in the way that the keys migrate so it's safer, first it will store them in the new location, and only then once that succeeds it will delete the old copy.

https://github.com/nighthawk-apps/nighthawk-ios-wallet/pull/8

pacu commented 10 months ago

Changed reviewed and merged https://github.com/nighthawk-apps/nighthawk-ios-wallet/pull/8