padarom / guacamole-common-js

:avocado: The JavaScript Guacamole client library modified for easy installation and usage via npm
http://guac-dev.org/
Apache License 2.0
41 stars 18 forks source link

Change representation of ü in the package.json author field #12

Closed jbarber closed 2 years ago

jbarber commented 2 years ago

The "ü" character in the "author" field was represented using the character 0xfc. This is correct for Unicode, but is an invalid character in UTF-8. From https://en.wikipedia.org/wiki/Specials_(Unicode_block):

The first and last byte are valid UTF-8 encodings of ASCII, but the middle byte (0xFC) is not a valid byte in UTF-8.

The presence of 0xFC is a problem because it causes tools that are strict about JSON files having UTF-8 encoding to fail.

padarom commented 2 years ago

Sounds good to me, thanks! Will push a patch release shortly.

jbarber commented 2 years ago

Thanks!