version 1.4 ignore header

padarom / guacamole-common-js

:avocado: The JavaScript Guacamole client library modified for easy installation and usage via npm

http://guac-dev.org/

Apache License 2.0

41 stars 18 forks source link

version 1.4 ignore header #16

Closed Veiintc closed 2 years ago

Veiintc commented 2 years ago

this is guacamole-common-js@1.4.0 but I see github, it should three args and I install guacamole-common-js@1.3.1,it had three args

padarom commented 2 years ago

Mh I'm unsure how this happened. The distributable files were regenerated after I updated from upstream, so not sure how it ended up with just one argument. I just regenerated them again and now everything seems in order:

Guacamole.HTTPTunnel = function(tunnelURL, crossDomain, extraTunnelHeaders) {

I just published these as a patch 1.4.0-a. Thanks for pointing this out and apologies for the inconvenience!

Veiintc commented 2 years ago

Thank you for your quick reply

TaeHyunChi commented 2 years ago

The extraTunnelHeaders is not sent while making a request in 1.4.x so I did fix it by restoring version 1.3.1