search

padarom / guacamole-common-js

:avocado: The JavaScript Guacamole client library modified for easy installation and usage via npm
http://guac-dev.org/
Apache License 2.0
41 stars 18 forks source link

The extraTunnelHeaders is not sent while making a request in 1.4.x #17

Closed TaeHyunChi closed 2 years ago

TaeHyunChi commented 2 years ago

The extraTunnelHeaders is not sent while making a request in 1.4.x so I did fix it by restoring version 1.3.1

Originally posted by @TaeHyunChi in https://github.com/padarom/guacamole-common-js/issues/16#issuecomment-1073695791

padarom commented 2 years ago

Were you using 1.4.0? After this was reported in #16 I published a follow-up patch 1.4.0-a. I just installed that version locally and to me its files look fine:

Bildschirmfoto 2022-03-28 um 13 55 43
AndreasHerz commented 2 years ago

Why not @1.4.1? I guess it`s not a pre-release 🤔

padarom commented 2 years ago

Because I want to keep the versioning scheme of this npm library in line with upstream Guacamole. If they end up releasing 1.4.1 it clashes with the version number I chose, see https://github.com/padarom/guacamole-common-js#version-numbers