search

padawan-php / padawan.php

php intelligent code completion http server
http://mkusher.name/padawan/
MIT License
253 stars 30 forks source link

Use separate method, keep promise interface intact #81

Closed halftan closed 10 months ago

halftan commented 7 years ago

76

mkusher commented 7 years ago

I think the right approach would be to return promise from save and use save, but before use blocking op.

halftan commented 7 years ago

But unblocking op is meaningless when running padawan generate in terminal.

2016-12-29 17:27 GMT+08:00 Aleh Kashnikau notifications@github.com:

I think the right approach would be to return promise from save and use save, but before use blocking op.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mkusher/padawan.php/pull/81#issuecomment-269603320, or mute the thread https://github.com/notifications/unsubscribe-auth/ABz2eM12LTCgttdzGmS-jvgsWZSCqaJbks5rM30egaJpZM4LXcdp .

mkusher commented 7 years ago

I don't think that it is meaningless, because later we can use different files for index and continue parsing while some file is saving