padcom / grails-routing

Apache License 2.0
30 stars 31 forks source link

Configurable dynamic methods #37

Closed mifi closed 10 years ago

mifi commented 10 years ago

Created a CamelMessageService for use instead of invasively setting generic metaclass property names like "sendMessage" on all Controllers/Services/Jobs. sendMessage is likely to clash with existing methods.

Injected dynamic method names can be disabled by using the config option: grails.routing.disableDynamicMethods = true

aahutsal commented 10 years ago

Sorry, but: a) this is a breaking change b) it's abit fool to access service every time we need to call sendMessage and other functions.

Declining this pool request.

mifi commented 10 years ago

Why is it a breaking change if it is configurable and defaults to normal behaviour? It's more verbose, yes, but it's also safer and prevents obscure bugs

aahutsal commented 10 years ago

It's abit crazy to autowire your service everytime sendMessage method is needed.

2014/1/8 mifi notifications@github.com

Why is it a breaking change if it is configurable and defaults to normal behaviour? It's more verbose, yes, but it's also safer and prevents obscure bugs

— Reply to this email directly or view it on GitHubhttps://github.com/padcom/grails-routing/pull/37#issuecomment-31874838 .

Arsen

mifi commented 10 years ago

Ok, but i disagree

aahutsal commented 10 years ago

This is decision made by me and padcom (the project owner). Sorry about that.

2014/1/9 mifi notifications@github.com

Ok, but i disagree

— Reply to this email directly or view it on GitHubhttps://github.com/padcom/grails-routing/pull/37#issuecomment-31936962 .

Arsen

mifi commented 10 years ago

I understand :)

aahutsal commented 9 years ago

Hi padcom/grails-routin,

I'd like to add you to my professional network on LinkedIn.

Accept: http://www.linkedin.com/blink?simpleRedirect=d3oOdPoMcPkQdPwNd3wUdjgVdjR4imVLqnhxt6BSrCAChPlor6NHsCsZumlbp6lOomxP9DhPpnlDnSlQqnpKqjRHpipxt6cJpnhFtCVFbnhPpnlDbmNJpjRDrCBHoS5Ot2pBt6BSrABDpl9BsD0ZoioTbj9BpnBKe3dFbmZDrCFVt3RBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I8498934033_1&markAsRead=

You received an invitation to connect. LinkedIn will use your email address to make suggestions to our members in features like People You May Know. Unsubscribe here: http://www.linkedin.com/blink?simpleRedirect=0Tbj9BpnBKe3dFbmZDrCFVt3RAqmkCjmZCijxIcDFHdmIRujlegRlAcSdpqR99pA5GnRd1sApBgPxGl6JkmCBotzhEomZSkkJNunxGlQRLk7B1nSdSqSxdimRnhkUPqnxNjChngQxSpQhnmAV3t6Ncrmt2iB1Eh5dlmBtnr5ZEc396j7pMh4Jqr3BBs6Z6k7pyunhIh6Z9gzB8oPcMhD0NqSVJkkthrRl1gk5he4wQkBlMtABaqkphgjRAqmZI9DhPpnlDnSlQqnpKqjRHpiphdzdAhktElApOrkphgjRKpmJLl6hFripKtmMZt2oTbj9BpnBKe3dFbmZDrCFVt3RBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I8498934033_1&markAsRead=This email was intended for padcom/grails-routin padcom/grails-routing. Learn why we included this at the following link: http://www.linkedin.com/blink?simpleRedirect=0Ue3sQfmh9pmNzqnhOoipQsSlRpRZBt6BSrCAZqSkCr79lpmdFtD9BkT9BrmZQsTlzfm4CdOQOpmlVrzwPqiRLpSVGungZpjYOtyZBbSRLoOVKqmhBqSVFr2VTtTsLbPFMt7hE&msgID=I8498934033_1&markAsRead= © 2014, LinkedIn Corporation. 2029 Stierlin Ct. Mountain View, CA 94043, USA

aahutsal commented 9 years ago

Arsen Gutsal would like to connect on LinkedIn. How would you like to respond?

Accept: http://www.linkedin.com/blink?simpleRedirect=d3oOdPoMcPkQdPwNd3wUdjgVdjR4imVLqnhxt6BSrCAChPlor6NHsCsZumlbp6lOomxP9zANnT1UplZSrCAZqSkCsClArCBJpn8Jt71BoSdxbm8JpTpKqlZJrmZzbmNJpjRDrCBHoS5Ot2pBt6BSrABDpl9BsD0ZoipEbn5KqndLpzdFbmZDrCFVt3RBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I8498934033_500&markAsRead=

View Arsen Gutsal's profile: http://www.linkedin.com/blink?simpleRedirect=0VclZMu6lvtCVFfmJB9D9Bp6VFrmlObnhMpmdzoiRybmtSrCBvrmRLoORIrmkZpSVFqSdxsDgCtD1KfngCq2RNrCBPrSoPqiRLpSVGungZpjYOtyZBbSRLoOVKqmhBqSVFr2VTtTsLbPFMt7hE&msgID=I8498934033_500&markAsRead=

You are receiving Reminder emails for pending invitations. Unsubscribe here: http://www.linkedin.com/blink?simpleRedirect=1JrSd5cylytmxQqmt5cylVr71Bsz0Q9jsNcjcQdz4Jcj5Bom9BczBCdzAPpj9zoz4Ue64Me6hAcS4Qe3lCpjxBcj0VcS9BcyQRcP4Qc34RcyRFgz8BumNMpn8Zr6BxrmkCc3oMc38Zp6ACd3oOdPoMcPkQdPwNd3wUdjgVdjRAqmsCej5vs7xBnTpKqjRHpipytndKtiRCbmdypmRvrmRLoORIrmkZpSVFqSdxsDgCrSZDfngCq2RNrCBPrSoPqiRLpSVGungZpjYOtyZBbSRLoOVKqmhBqSVFr2VTtTsLbPFMt7hE&msgID=I8498934033_500&markAsRead=

You received an invitation to connect. LinkedIn will use your email address to make suggestions to our members in features like People You May Know. Unsubscribe here: http://www.linkedin.com/blink?simpleRedirect=6wJsmVFsSZCcSAJrStKqDBQfmhFpipHl3perSVecTt8gzhBu3oJemdygBhmljxes49nr3pUuj9ckkRPp5ZqmmQVq6BUtChLjSdqp7BypzoStSgNcP93rzpWjmZ3tkpNj45Uj31ki4ZkhBlbqj1HqRp7lSVvtQVqk6x8u5FQh6RGi4xQskJptP1xtBZ7r6FesAlPpQFihlphhkt6h51eh4lhjQBhon1Llk51gmtqkS9hnP9KkRcMi551fmhFrSMCej5vs7xBnTpKqjRHpiphdzdAhktElApOrkphgjRKpmJLl6hFripKtmMZt2pEbn5KqndLpzdFbmZDrCFVt3RBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I8498934033_500&markAsRead= Learn why we included this at the following link: http://www.linkedin.com/blink?simpleRedirect=3wUdPgZp4BBr6dFt79x9zANnT1UplZSrCAZqSkCr79lpmdFtD9BkT9BrmZQsTlzfm4Cq2RNrCBPrSoPqiRLpSVGungZpjYOtyZBbSRLoOVKqmhBqSVFr2VTtTsLbPFMt7hE&msgID=I8498934033_500&markAsRead= © 2014, LinkedIn Corporation. 2029 Stierlin Ct. Mountain View, CA 94043, USA

aahutsal commented 9 years ago

Arsen Gutsal would like to connect on LinkedIn. How would you like to respond?

Accept: https://www.linkedin.com/blink?simpleRedirect=0Qdz8Tdz0PdjgTe34Qe3wRd3ARfkh9rCZFt65QqnpKqip7dlxIr6JOpPRVpkJApn9xq7cCej5vs7xBnTpKqjRHpipOpmhKqmRBsyRQs6lzoS4JoyRDtCVFnSRJrScJr6RBfmtKqmJzon9Q9ClQqnpKimtBkClOs3Rx9CwPbmkQe6dLs3dFbmZDrCFVt3RBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I8498934033_500&markAsRead=

View Arsen Gutsal's profile: https://www.linkedin.com/blink?simpleRedirect=ej5vs7xBnTpKqjRHpipOpmhKqmRBsyRQs6lzoS4JoyRDtCVFnSRJrScJr6RBfmtKqmJzon9Q9DpMrzRQ9CwPbmkQe6dLs3dFbmZDrCFVt3RBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I8498934033_500&markAsRead=

You are receiving Reminder emails for pending invitations. Unsubscribe here: https://www.linkedin.com/blink?simpleRedirect=rmZzhj8BoDlEt6BDhj8BumNMpn8Md2kTcj4Pd3oNbj4Npm5ypj8VpzoVcSkOoS8Ne3xxc3xAp3dxd3wRpCkUpj4Mejdypj8JdjcNd30Ndj8Jqk8O9nBIs6lOfmNFomRB9z0Sc30OfmhF9zgSczsSc3cRd3sUcjgUe3kQejkZp6BD9zANnT1UplZSrCAZqSkCoDlPrDkJpyRzoClJnSRJrScJr6RBfmtKqmJzon9Q9CZLpPRQ9CwPbmkQe6dLs3dFbmZDrCFVt3RBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I8498934033_500&markAsRead=

You received an invitation to connect. LinkedIn will use your email address to make suggestions to our members in features like People You May Know. Unsubscribe here: https://www.linkedin.com/blink?simpleRedirect=1EcORBd3xzrT0PqiRLpSVGungZp6BB9BBHqBtflD1momZ8oTdbkBBSe7lBonBTomt4eklLjzx4lCJOdAxmmmwNdABIpTtEiQoVnSNAmD4UrAxJp7hhliRfmmwOlB57hmlIh64NkkN2qRFpi79HtlBGlkBphC4Nbjd1cn9almRot59ilRt9k4oSoP11kTxOoD56e71fm7BWlCVijn55ckVEmlpkc5ZqjD1lgk51tTl7j6lKdQd8jlZ7kk4Zp6BLr2oVclZMu6lvtCVFfmJB9B4ScSh5hSxmhD9JhB51fmVBqSZkp6BJ9CVRr3RQ9CwPbmkQe6dLs3dFbmZDrCFVt3RBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I8498934033_500&markAsRead= Learn why we included this at the following link: https://www.linkedin.com/blink?simpleRedirect=0Ue3sQfmh9pmNzqnhOoioVclZMu6lvtCVFfmJB9CNOlmlzqnpOpldOpmRLt7dRoPRx9CwPbmkQe6dLs3dFbmZDrCFVt3RBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I8498934033_500&markAsRead= © 2014, LinkedIn Corporation. 2029 Stierlin Ct. Mountain View, CA 94043, USA