search

paddybyers / anode

Android framework for node.js applications
Other
583 stars 80 forks source link

Added LOCAL_LDFLAGS so the build will find the locally linked crypto and... #3

Closed eelcocramer closed 12 years ago

eelcocramer commented 12 years ago

... ssl libs. This way there is no need to create symbolic links in the NDK to these files.

paddybyers commented 12 years ago

I don't want to bind the library to the locally built libraries. I want it to use the libraries that are already present in usr/lib, either on the emulator or the phone.

Doesn't your patch prevent the library from linking against the system libraries?

Building the libraries locally is only done because the NDK does not include these libraries, even though they are present on the target.

eelcocramer commented 12 years ago

You need to link to the libraries you build yourself since they are not present in the NDK. It does not matter where these libraries are located. At runtime (on the device or on the emulator) the system will dynamically look up the libraries to use.

The only thing my patch changes is that it looks for the libraries relative to the instead of creating a symlink to (the same) libraries and acting if these are the system libraries.

My patch does impact the build instructions when using the prebuilt binaries.

On Tue, Dec 20, 2011 at 5:18 PM, paddybyers reply@reply.github.com wrote:

I don't want to bind the library to the locally built libraries. I want it to use the libraries that are already present in usr/lib, either  on the emulator or the phone.

Doesn't your patch prevent the library from linking against the system libraries?

Building the libraries locally is only done because the NDK does not include these libraries, even though they are present on the target.

Reply to this email directly or view it on GitHub: https://github.com/paddybyers/anode/pull/3#issuecomment-3221008

paddybyers commented 12 years ago

OK, merged, thanks.

Note that on the bridge branch, it will need to be different again because the build config has changed again, but we can do the same thing just with a different location.