Inclusion order for <limits.h> and <sys/mman.h>

paddybyers / node

evented I/O for v8 javascript

http://nodejs.org/

Other

92 stars 24 forks source link

Inclusion order for <limits.h> and <sys/mman.h> #11

Open paddybyers opened 13 years ago

paddybyers commented 13 years ago

deps/libeio/eio.c contains a conditional inclusion of <sys/mman.h>. The logic for this breaks on Android, because the relevant variable (_POSIX_MAPPED_FILES) is in which is currently included after the variable is tested.

Suggest fix is here:

https://github.com/paddybyers/node/commit/1b6bd89173fa05bc18483158893a0f719427b5ea https://github.com/paddybyers/node/commit/55b94d213085f41f8bb63c638acbbfeecd2614b8

paddybyers commented 13 years ago

This is also an issue for master.

Suggested fix is here:

https://github.com/paddybyers/node/commit/f3bd63074cb410774563fd587c24c3ddd4498644