search

paddybyers / node

evented I/O for v8 javascript
http://nodejs.org/
Other
91 stars 24 forks source link

utils/Log.h conditionally available on Android #7

Open paddybyers opened 12 years ago

paddybyers commented 12 years ago

deps/v8/src/platform-posix.cc contains a dependency on <utils/Log.h>

This is available in the Android open source project (AOSP) but not in the NDK. For an NDK build, there needs to be a way to remove the dependency.

Current workaround is to have an Android-specific condition indicating whether or not the private AOSP includes are available:

https://github.com/paddybyers/node/commit/a427c81ac986c6339d5b30de78bc0310987c7743

paddybyers commented 12 years ago

There's a slightly different issue on master. The newer v8 already has a conditional V8_ANDROID_LOG_STDOUT but it forgets to make the include itself conditional on that.

Fix is here:

https://github.com/paddybyers/node/commit/622f690ef661b9dc69e948e4f72a8bd3f9e6fca4