search

paddybyers / node

evented I/O for v8 javascript
http://nodejs.org/
Other
91 stars 24 forks source link

macros.py processing for Android build #8

Closed paddybyers closed 12 years ago

paddybyers commented 12 years ago

`The issue is whether or not to build macros.py dynamically in the Android port, or just to commit the file. If it is committed, then where?

The Android platform does not support Dtrace so there is no real requirement for this to be programmatically generated.

The current workaround is to hard-code the contents of macros.py and this is committed at the top-level, although this is clearly not a general solution.

https://github.com/paddybyers/node/commit/a58cae664d96c420d50a15fa2c36941b5c15c0c9

paddybyers commented 12 years ago

Now also on master:

https://github.com/paddybyers/node/commit/d0189181753a51689b707be75cd4764e341868ac

paddybyers commented 12 years ago

In fact, this is no longer an issue on master - there is a src/macros.py already in the repo.

Now removed:

https://github.com/paddybyers/node/commit/69dafe01c4fd05df98beb5c6b1ebd05e295b479b