search

paddycarey / dweepy

A Simple Python client for Dweet.io
MIT License
60 stars 18 forks source link

Added optional session to all API calls #7

Closed SideshowAlex closed 7 years ago

SideshowAlex commented 8 years ago

An optional session parameter has been added to all API call to enable the reuse of existing request sessions. This can be used to reduce the overhead incurred from establishing HTTP/HTTPS connections, and to allow the callers to take advantage of the features of the request session.

The addition of the session parameter has been introduced to preserve backwards compatibility with the existing API calls.

paddycarey commented 8 years ago

Thanks for this! It looks good on the surface but let me try to fix up travis and get the tests passing before merge. I should have time to look at it in a few days.

In the meantime, could you also add a small note to the documentation about your change?

SideshowAlex commented 8 years ago

Sorry about the lateness of my reply. Sometimes real work gets in the way of the fun stuff...

I've added a little blurb in the README. Hope it is what you were expecting. If not, I can modify it.

paddycarey commented 8 years ago

README looks good, thanks! Sorry I haven't had time yet to resolve the test failures, hopefully this weekend.

paddycarey commented 7 years ago

Sorry for the delay, LGTM