Add tooltips to Histograms - Githubissues

paddymul / buckaroo

Buckaroo - the data wrangling assistant for pandas. Quickly explore dataframes, and run pandas commands via a GUI. Works inside the jupyter notebook.

https://paddymul.github.io/buckaroo/

BSD 3-Clause "New" or "Revised" License

227 stars 9 forks source link

Add tooltips to Histograms #291

Closed paddymul closed 3 weeks ago

paddymul commented 1 month ago

Checks

[X] I have checked that this issue has not already been reported.
[X] I have confirmed this bug exists on the latest version of Buckaroo.

What type of jupyter notebook were you using (VSCode notebook, google colab, Jupyter Lab, Jupyter notebook). Select multiple if you can reproduce this in multiple environments. If other, please add to description.

Jupyter Lab

Reproducible example

This currently doesn't work in the JS only examples.

Issue description

I think histograms used to have tooltips. There certainly is code to generate tooltips. It doesn't display

Expected behavior

Tooltips conveying histogram bar range should display

Installed versions

``` 0.7.4 ```

Jupyter Log output

No response

paddymul commented 1 month ago

I suspect this is related to https://github.com/paddymul/buckaroo/blob/57b850bcaf3463f45d0a904f8df2787fe2a5fcff/js/components/DFViewerParts/HistogramCell.tsx#L66-L89 and an upgrade of ag-grid. the tooltip handling was pretty custom

paddymul commented 3 weeks ago

related https://github.com/recharts/recharts/issues/5181#

paddymul commented 3 weeks ago

Fixed by da1bf14 release 0.7.9 https://github.com/paddymul/buckaroo/commit/da1bf14d5b64660eb9a314aadefffd597c04b737