Detect and correct uint8 underflow in temperature

padelt / temper-python

libusb/PyUSB-based driver to read TEMPer USB HID devices (USB ID 0c45:7401) and serve as a NetSNMP passpersist module

Other

182 stars 76 forks source link

Detect and correct uint8 underflow in temperature #74

Closed Zac-HD closed 7 years ago

Zac-HD commented 7 years ago

Negative actual temperatures would wrap to 256C, which is well outside the operating range of the device. This is a dead-simple fix, but a quick patch release would be appreciated to close home-assistant/home-assistant#4896.

padelt commented 7 years ago

It seems like your problem should be solved by the changes I just merged into master. Could you please retest with that?

Zac-HD commented 7 years ago

I can't retest, but #68 looks like the more correct way to handle this anyway.