search

padpadpadpad / rTPC

R package to help fit Thermal Performance Curves
https://padpadpadpad.github.io/rTPC/
22 stars 3 forks source link

thomas_2012() needs changing #51

Closed padpadpadpad closed 1 year ago

padpadpadpad commented 1 year ago

Behaviour of thomas_2012() is strange. Way of estimating limits does not seem to match with what the best fit to the data is. Not sure how to fix this tbh.

Maybe send Mridul Thomas an email. Also probably change Topt to Tref because it only equals Topt when b = 0.

padpadpadpad commented 1 year ago

Having checked with Mridul, he says values of -100 to +100 may be suitable for upper and lower limits, made them +/- 200 to make sure.

padpadpadpad commented 1 year ago

fixed in latest commit 77ef5ed