Option "VPN DNS Server" doesn't work

[GoogleCodeExporter]

What steps will reproduce the problem?
1. edit Preferences the a config.
2. enable "Use VPN DNS Server"
3. go back and connect to the server.

What is the expected output? What do you see instead?
  Expect DNS be set to the one I entered after connected.
  Actually DNS haven't been changed.
What version of the product are you using? On what operating system?
  0.4.3test1

Please provide any additional information below.

Following diff can fix it.

git diff HEAD~1          
diff --git 
a/src/main/src/de/schaeuffelhut/android/openvpn/EditConfigPreferences.java 
b/src/main/src/de/schaeuffelhut/android/openvpn/EditConfigPreferences.java
index 2653c00..ecf675e 100644
--- a/src/main/src/de/schaeuffelhut/android/openvpn/EditConfigPreferences.java
+++ b/src/main/src/de/schaeuffelhut/android/openvpn/EditConfigPreferences.java

@@ -60,8 +60,8 @@ public class EditConfigPreferences extends PreferenceActivity

        private void renamePreference(String oldKey, String newKey) {
                Preference pref = findPreference( oldKey );
-               pref.setKey( newKey );
                getPreferenceScreen().removePreference( pref );
+               pref.setKey( newKey );
                getPreferenceScreen().addPreference( pref );
        }

Original issue reported on code.google.com by iamtimgreen on 26 Jun 2010 at 11:50

[GoogleCodeExporter]

Please ignore this issue. It works fine.

According to PreferenceGroup.java, the order is not important.

Original comment by iamtimgreen on 26 Jun 2010 at 12:47

[GoogleCodeExporter]

Original comment by friedrich.schaeuffelhut on 16 Sep 2010 at 1:29

• Changed state: Invalid