search

padrino / padrino-framework

Padrino is a full-stack ruby framework built upon Sinatra.
http://www.padrinorb.com
MIT License
3.37k stars 509 forks source link

Add compatibility with Sinatra 3 #2259

Closed jkowens closed 1 year ago

jkowens commented 1 year ago

Sinatra 2.2.4 and 3.0.5 add a callers_to_ignore method that can be overridden instead of directly mutating CALLERS_TO_IGNORE.

nesquena commented 1 year ago

Much cleaner, thank you!

wakatara commented 1 year ago

Woo! \0/ So, does this mean we can look forward to a 0.15.2 this weekend?

wakatara commented 1 year ago

@nesquena And also, not to be too cheeky on the release front... would this result in padrino-core supporting a bundler above 1.0? I'm assuming that is a non-complicated (correct me if I'm wrong) change.

nesquena commented 1 year ago

@wakatara I would be happy to cut a release if we think it's ready.

@jkowens Should I bump this a major version or is everything that was changed non breaking?

Thoughts on Bundler version change?

jkowens commented 1 year ago

@nesquena no breaking changes were made, so I don't think a major version change would be necessary. It might be nice to get #2263 into the next release if possible.

nesquena commented 1 year ago

@nesquena no breaking changes were made, so I don't think a major version change would be necessary. It might be nice to get #2263 into the next release if possible.

Okay great, I went ahead and merged 2263 as well

Once I get the CircleCI setup it sounds like I can prepare a release then

Thanks again

nesquena commented 1 year ago

@nesquena no breaking changes were made, so I don't think a major version change would be necessary. It might be nice to get #2263 into the next release if possible.

@jkowens I believe the circle CI build is failing. Can you take a look at if it is an easy fix? Once circle CI passes on master branch, I can cut a release.

wakatara commented 1 year ago

Yey! Anything else you guys need done to cut the new release? I've got a bit of time between now and the new year. (and need to update the old software, so imagine I'll be bugging you anyway with lotsa, "why is X broken in 0.15.x vs 0.14.2" type questions when the upgrade doesn't blow up on bundle install... =] ).

nesquena commented 1 year ago

I was thinking of pushing out the release over the next few days unless anyone spots a reason not to, and I'll respond back here

nesquena commented 1 year ago

@jkowens @wakatara Thanks again to both of you, Jordan I really appreciate you doing the "heavy" lifting for this release. and Daryl for nudging the release and also for testing it after you upgrade and letting us know.

🚀 Alright, I updated everything, ran the tests which passed, and then deployed 0.15.2! Please let me know if everything is working okay on the latest version

wakatara commented 1 year ago

Woohoo! Very nice Xmas present. I'll do some work over the Yuletide on upgrading AArk (and probably ask all sorts of questions on why stuff is broken. =] (also, I'll put stuff in a blog post since I notice there's lots of little things (ActiveRecord connect hashes vs blocks of variabls etc Congrats @nesquena and @jkowens Yey! \0/

nesquena commented 1 year ago

That sounds great, thanks @wakatara, and long live Padrino! 😄