Is Rack::Protection still necessary?

padrino / padrino-recipes

A collection of padrino templates and plugins

http://www.padrinorb.com

292 stars 50 forks source link

Is Rack::Protection still necessary? #23

Closed fbernier closed 11 years ago

fbernier commented 12 years ago

While reading the Sinatra intro, I stumbled upon the following part:

http://www.sinatrarb.com/intro.html#Configuring%20attack%20protection

From what I understand, Rack::Protection is enabled by default in Sinatra. Having already installed it from the padrino-recipes in my app, I was wondering if it was superfluous to have a recipe for it.

Is there something I am missing?

DAddYE commented 12 years ago

@achiu ?

nesquena commented 12 years ago

You are right, that recipe was from before Sinatra had it baked in by default.

mariusbutuc commented 11 years ago

Good catch @fbernier, I strongly vote for cleaning it out then, to keep things simple. :+1:

It's been 11 months since this issue was open, I'd think it's about time to quickly handle it.

DAddYE commented 11 years ago

Yep will be removed soon. @achiu ?

DAddYE commented 11 years ago

Thaaaaaaaaaaanks!