search

padsley / k600analyser

Code for the K600 analyser including plugin codes for silicon, clover and HAGAR data
1 stars 4 forks source link

Ex #158

Closed padsley closed 5 years ago

padsley commented 7 years ago

I've been getting this question a lot so this is a form of broadcast message:

Ex computed by the analyser. You should not trust this thing. When I wrote the code, I think I only implemented it for inelastic scattering (so it definitely is bad for (p,t) and (3He,t)). In addition, part of the way through I realised that I didn't need or want it and so stopped using it. How complete and working it is is therefore an open question.

Now, it might have been fixed by someone else and be all fine. However, unless you actually check that explicitly, then do not trust it.

FWIW, this is something that should probably be fixed at some point and I shall have a look into it when I am able to do so (late 2020 is my next free time).

pellegri commented 7 years ago

Following this I check the Ex calculator and fix it on the PR251 branch. It should be generalised for all cases but if another coupled of eyes can double check it, it would be better… I’ll put it on github late today ;)

Luna

On 28 Mar 2017, at 12:46, Philip Adsley notifications@github.com wrote:

I've been getting this question a lot so this is a form of broadcast message:

Ex computed by the analyser. You should not trust this thing. When I wrote the code, I think I only implemented it for inelastic scattering (so it definitely is bad for (p,t) and (3He,t)). In addition, part of the way through I realised that I didn't need or want it and so stopped using it. How complete and working it is is therefore an open question.

Now, it might have been fixed by someone else and be all fine. However, unless you actually check that explicitly, then do not trust it.

FWIW, this is something that should probably be fixed at some point and I shall have a look into it when I am able to do so (late 2020 is my next free time).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/padsley/k600analyser/issues/158, or mute the thread https://github.com/notifications/unsubscribe-auth/AKA6lZ9dhJvSpfjs-NldNJMvt0qcK0Mbks5rqOT2gaJpZM4MrcZB.

padsley commented 7 years ago

Awesomesauce. Thanks for doing that.

I suggest that, as @LindsD was one of the people who was looking to use the Ex class, that she does the checking for it. (Sorry... for dropping you in it.)

neveling commented 7 years ago

I have used CalcEx before for inelastic scattering, and I was under the impression it is working fine for inelastic scattering.

Luna, am I correct that the only changes you did in your commit this afternoon "046591a fix the CalcEx function in FocalPlane.c" was the change the division of rigidity by another 1000 to align things with the SPANC output, and to add Q?

pellegri commented 7 years ago

At the begging I wrote another function to calculate it and I compare the results with the one that Phil wrote and they were the same. So then I left the Phil one active and I double check the calculation and generalise for other cases than inelastic scattering. Although I don't have data to check if this part is right so maybe it's easier if someone that is analysing that kind of data can check that. I've also changed as you noticed the conversion factor for the QBrho.

For the kinematic calculations I made some notes. I will send them to you tomorrow.

Cheers, Luna

On 28 Mar 2017, at 17:48, neveling notification@github.com wrote:

I have used CalcEx before for inelastic scattering, and I was under the impression it is working fine for inelastic scattering.

Luna, am I correct that the only changes you did in your commit this afternoon "046591a fix the CalcEx function in FocalPlane.c" was the change the division of rigidity by another 1000 to align things with the SPANC output, and to add Q?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

pellegri commented 7 years ago

@neveling I just realized that the kinematics calculator is implemented on PR251 branch only. We should merged these changes in the master branch as well. Not sure how to do it but I could try...

padsley commented 7 years ago

Merge that sh*t.

neveling commented 7 years ago

I see there is still an open pull request on PR251??

pellegri commented 7 years ago

Done :P