Sifundo @SifundoDelton has been having problems with junk timing values (around -2e7 units) for the TDCs for the PR242 analysis, which didn't match what we saw online.
Having done a bit of digging the problem was that the main.c file has a fixed array size for cableOffsets which get read in from the CableLengths.dat file. This size is hard-coded as 896 which is 7 TDC modules but he had 8 TDC modules for PR242. We changed the hardcoding for this and added a function which zeros the TDC values meaning that we don't get weird junk values anymore. However, at some point these things should be changed to read dynamically from the parameters input file and not be hard-coded (which shouldn't be too hard since most of the information is already there, we just need to add it/use it properly but I never notice until it breaks).
Sifundo @SifundoDelton has been having problems with junk timing values (around -2e7 units) for the TDCs for the PR242 analysis, which didn't match what we saw online.
Having done a bit of digging the problem was that the main.c file has a fixed array size for cableOffsets which get read in from the CableLengths.dat file. This size is hard-coded as 896 which is 7 TDC modules but he had 8 TDC modules for PR242. We changed the hardcoding for this and added a function which zeros the TDC values meaning that we don't get weird junk values anymore. However, at some point these things should be changed to read dynamically from the parameters input file and not be hard-coded (which shouldn't be too hard since most of the information is already there, we just need to add it/use it properly but I never notice until it breaks).