search

paed01 / bpmn-engine

BPMN 2.0 execution engine. Open source javascript workflow engine.
MIT License
884 stars 167 forks source link

Removing wrong event listener in the case of an error. #148

Closed allain closed 2 years ago

allain commented 2 years ago

Hello. I was reading the code and realise that it should be removing the event listener for onEvent rather than onError.

https://github.com/paed01/bpmn-engine/blob/fef68c68ab4a0fd24b24be41055d646102813265/index.js#L249

paed01 commented 2 years ago

You are absolutely right! Silly mistake.

allain commented 2 years ago

No problem. Want me to PR?

paed01 commented 2 years ago

@allain your version is published. I added some tests to make sure it won't happen again.