paf31 / purescript-behaviors

A simple push-pull FRP implementation
MIT License
135 stars 21 forks source link

updates for 0.12 #36

Closed justinwoo closed 6 years ago

justinwoo commented 6 years ago

bunch of updates for 0.12 and filterable, wip.

Not entirely sure if compactable is supposed to be implemented in a different way.

paf31 commented 6 years ago

Thanks! Looks good, I'll merge this after the compiler is released. Until then, your branch can be used in the package set, right?

justinwoo commented 6 years ago

Yup, that's what I'm planning to do for now: https://github.com/purescript/package-sets/pull/175/

justinwoo commented 6 years ago

Good to merge? only depends on https://github.com/purescript-contrib/purescript-drawing/pull/27 which is a dev dependency

justinwoo commented 6 years ago

Is there anything missing here? I really want to upgrade my underlying lib and my chatbot~

paf31 commented 6 years ago

I'd like to review open PRs but I haven't had time. I'll get to it soon, I hope. Sorry for the delay.

thomashoneyman commented 6 years ago

I'm working on migrating a few libraries that depend on behaviors. Anything that I can do to help with this PR?

paf31 commented 6 years ago

I'm working through PRs slowly. This one will be next, but I'm thinking I'll break the Event part out into a separate package, since people seem to use that more than Behavior.

justinwoo commented 6 years ago

Sounds fair

thomashoneyman commented 6 years ago

@paf31 Is it possible to release a new version of this library for 0.12 compatibility alone?

It would make for an easier transition for folks like @justinwoo and my team and likely less stress for you if this (and libraries like parsing) were available in their current form for 0.12, and later, when you have time & at your convenience, another update could be made to break Event out to a separate package.

Halogen updated this way and it's been quite nice; they get to relax and take their time working on the next big improvement to the library, but the rest of the dependent ecosystem can complete the transition to 0.12 without relying on forks.

justinwoo commented 6 years ago

@thomashoneyman If it helps, I'm using this package from psc-package like so: https://github.com/justinwoo/spacchetti/blob/92db49a1b119d919e682f3f213203e6dbd4e7d94/src/groups/patches.dhall#L18

thomashoneyman commented 6 years ago

Thanks @justinwoo. That helps make it possible to use your fork easily with psc-package, though it doesn't resolve relying on a fork vs. an official 0.12 release. We're considering whether to work with forks or continue to wait things out, and would very much prefer to avoid forking where possible. Regardless, thanks for the tip!

paf31 commented 6 years ago

Thanks!

paf31 commented 6 years ago

purescript-event is now broken out. I'm waiting on drawing, which is waiting on canvas, and when those are done, I'll finish this up and make a release. For now, this is merged so you can refer to it by the hash of master.