Closed ihavenick closed 1 year ago
Hi! Is it posible to have a download link for 5.1?
OMG Thanks!!!!!!!!
OMG Thanks!!!!!!!!
Any idea how to make it work?
Change the codes and rebuild the plugin , you can google how to rebuild the plugins
Rwanlink @.***> 于2022年10月9日周日 08:18写道:
OMG Thanks!!!!!!!!
Any idea how to make it work?
— Reply to this email directly, view it on GitHub https://github.com/pafuhana1213/KawaiiPhysics/pull/61#issuecomment-1272418938, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASO3UACQ2D2UWA37RR3CCDTWCIFM7ANCNFSM6AAAAAAQJ2RYIQ . You are receiving this because you commented.Message ID: @.***>
Suggested changes for supporting previous versions to KawaiiPhysicsEd:
BuildVersion Version;
if (BuildVersion.TryRead(BuildVersion.GetDefaultFileName(), out Version))
{
if (Version.MajorVersion == 5)
{
PrivateDependencyModuleNames.AddRange(new string[] { "EditorFramework" });
if (Version.MinorVersion >= 1)
{
PrivateDependencyModuleNames.AddRange(new string[] { "AnimationEditMode" });
}
}
}
There are unnecessary overrides, you override Enter()
Exit()
and AddReferencedObjects()
with empty bodies in both FKawaiiPhysicsEditMode
which inherits from FKawaiiPhysicsEditModeBase
which is already doing the same thing.
Also if you're going to PR you should format the code properly so it matches the author's, lot of indentation and lack of line breaks.
@Cruk-Leo Thanks it worked!
Voicing agreement with @Vaei : Formatting should match existing author's work as closely as possible, and remove redundant overrides.
Voicing agreement with @Vaei : Formatting should match existing author's work as closely as possible, and remove redundant overrides.
Redundant overrides must be there. Author must be implement that mandetory overrides.
And yes, I need to organize them but I am lazy. I am posting this for quickfix until Author comes back online.
Hi guys! Thanks to you , I were able to support UE5.1! https://github.com/pafuhana1213/KawaiiPhysics/commit/454f3de311438645e4f0af4e591f7a70fb1cc3c9
This update fixed some error and improve class design.
Updated for 5.1
Thanks!
Fix for the upcoming Unreal 5.1 changes