search

pagarme / superbowleto

:football: A microservice to issue, register and manage boletos
MIT License
5 stars 0 forks source link

lint: add tslint setup #208

Closed vcapretz closed 7 years ago

vcapretz commented 7 years ago

Description

Using linting tools is very important for code pattern and as you use TypeScript, changing from eslint to tslint could bring more validations specific to TypeScript, it can extend eslint configs and also check for other stuff. What do you think about it?

Thor99 commented 7 years ago

That's a nice idea! Would you mind open a PR?

vcapretz commented 7 years ago

No problem! I’ll do it!

VS Code also integrates very well with the tslint plugin (just a tip for who uses it 😉)

On 21 Jul 2017, at 11:32, Thor Garcia Rangel notifications@github.com wrote:

That's a nice idea! Would you mind open a PR?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

vcapretz commented 7 years ago

After setting up tslint there were some new errors, should I treat them in this same issue (and in one PR), or in multiple ones?

image

felquis commented 7 years ago

@vcapretz in this situation I'd do the following:

  1. we first add the linter commit it
  2. then use the fix and commit the automatic fixes
  3. then fix manually the remaining warnings, commit then

All in one PR because we don't want the CI failing in the master branch.