pagarme / superbowleto

:football: A microservice to issue, register and manage boletos
MIT License
5 stars 0 forks source link

lint: add tslint to the project #232

Closed vcapretz closed 7 years ago

vcapretz commented 7 years ago

Description

As we were using eslint for linting TypeScript files, this commit introduces tslint to the project

The tslint.json file contains the rules and extends the airbnb style guide adapted for tslint

The npm run lint command now run both eslint and tslint

Some variable names weren't changed as they are exported and used in many different files

it closes #208

Your checklist for this pull request

:rotating_light: Please review this items for a good pull request. :four_leaf_clover:

  1. I've read the project's Contributing Guidelines
  2. My commits are well written and follow pagarme/git-style-guide
  3. My changes are well covered by tests and logs
  4. I've updated the project docs (if needed)
  5. I fell safe about this implementation
  6. I feel confortable with the code I wrote, and I'm not ashamed to show it to my friends

In a good pull request, everything above is true :relaxed:

vcapretz commented 7 years ago

@grvcoelho

GitCop commented 7 years ago

There were the following issues with your Pull Request

Check out our Git Style Guide here: https://github.com/pagarme/git-style-guide


This message was auto-generated by https://gitcop.com

GitCop commented 7 years ago

There were the following issues with your Pull Request

Check out our Git Style Guide here: https://github.com/pagarme/git-style-guide


This message was auto-generated by https://gitcop.com

vcapretz commented 7 years ago

@grvcoelho @marquinhoalm done! :D

vcapretz commented 7 years ago

@grvcoelho deixei então superbowleto e minimizei apenas o stage mesmo! com a apikey passada do limite, coloquei o tslint:disable no começo do arquivo

marquinhoalm commented 7 years ago

@vcapretz Parabéns pelo PR!

grvcoelho commented 7 years ago

@vcapretz: obrigado pelo PR :)