pagarme / superbowleto

:football: A microservice to issue, register and manage boletos
MIT License
5 stars 0 forks source link

bradesco: use now() as bradesco's data_emissao parameter #257

Closed grvcoelho closed 6 years ago

grvcoelho commented 6 years ago

Description

We are now using the current moment as Bradesco's data_emissao parameter instead of boleto's created_at property. We're doing this to avoid errors with boletos that are created at one day and sent to register in another day. E.g. a boleto created at 23:59:59 on day 1 will be sent to register on 00:00:00 on day 2. Because bradesco only consider the date in a YYYY-MM-DD format, this would fail.

closes https://github.com/pagarme/ghostbusters/issues/85

Your checklist for this pull request

:rotating_light: Please review this items for a good pull request. :four_leaf_clover:

  1. I've read the project's Contributing Guidelines
  2. My commits are well written and follow pagarme/git-style-guide
  3. My changes are well covered by tests and logs
  4. I've updated the project docs (if needed)
  5. I fell safe about this implementation
  6. I feel comfortable with the code I wrote, and I'm not ashamed to show it to my friends

In a good pull request, everything above is true :relaxed:

GitCop commented 6 years ago

There were the following issues with your Pull Request

Check out our Git Style Guide here: https://github.com/pagarme/git-style-guide


This message was auto-generated by https://gitcop.com