search

pagarme / superbowleto

:football: A microservice to issue, register and manage boletos
MIT License
5 stars 0 forks source link

project: remove serverless framework #263

Closed grvcoelho closed 6 years ago

grvcoelho commented 6 years ago

Description

Remove everything related to the Serverless Framework as we do not use anything from it anymore. Also go back to using npm instead of yarn, as we're now using Node8 with npm5.

This closes https://github.com/pagarme/ghostbusters/issues/21 (internal issue tracking)

Your checklist for this pull request

:rotating_light: Please review this items for a good pull request. :four_leaf_clover:

  1. I've read the project's Contributing Guidelines
  2. My commits are well written and follow pagarme/git-style-guide
  3. My changes are well covered by tests and logs
  4. I've updated the project docs (if needed)
  5. I fell safe about this implementation
  6. I feel comfortable with the code I wrote, and I'm not ashamed to show it to my friends

In a good pull request, everything above is true :relaxed:

grvcoelho commented 6 years ago

Shouldn't the commit project: use npm as package manager remove the yarn.lock file?

@otaviopace yep, you're right! I just fixed it.

evaporei commented 6 years ago

The yopa-config.yml will still be used because the project will still use sqs queue right?

grvcoelho commented 6 years ago

@otaviopace yes :+1: