search

pagarme / superbowleto

:football: A microservice to issue, register and manage boletos
MIT License
5 stars 0 forks source link

tests: refactor functional tests to actually request the web application #270

Closed evaporei closed 6 years ago

evaporei commented 6 years ago

Description

Create functional/e2e tests that actually request the web-server.

Your checklist for this pull request

:rotating_light: Please review this items for a good pull request. :four_leaf_clover:

  1. I've read the project's Contributing Guidelines
  2. My commits are well written and follow pagarme/git-style-guide
  3. My changes are well covered by tests and logs
  4. I've updated the project docs (if needed)
  5. I fell safe about this implementation
  6. I feel comfortable with the code I wrote, and I'm not ashamed to show it to my friends

In a good pull request, everything above is true :relaxed:

this closes https://github.com/pagarme/ghostbusters/issues/32

evaporei commented 6 years ago

@grvcoelho queria saber o que acha da linha 41 do arquivo que testa POST em /boletos. Eu coloquei lá, mas não sei até que ponto deveria haver uma conversão de string para inte se essa linha deveria ser removida.