search

pagarme / superbowleto

:football: A microservice to issue, register and manage boletos
MIT License
5 stars 0 forks source link

config: improve the way configs are done #275

Closed grvcoelho closed 6 years ago

grvcoelho commented 6 years ago

Description

Move bradesco provider configuration from credstash to a static config filed. This way, we move from an async approach to a sync one.

Also, remove everything related to lambda invocation.

This closes https://github.com/pagarme/ghostbusters/issues/13 (internal)

Your checklist for this pull request

:rotating_light: Please review this items for a good pull request. :four_leaf_clover:

  1. I've read the project's Contributing Guidelines
  2. My commits are well written and follow pagarme/git-style-guide
  3. My changes are well covered by tests and logs
  4. I've updated the project docs (if needed)
  5. I fell safe about this implementation
  6. I feel comfortable with the code I wrote, and I'm not ashamed to show it to my friends

In a good pull request, everything above is true :relaxed:

evaporei commented 6 years ago

Não acha válido remover do arquivo src/resources/boleto/index.js as funções register, processBoletosToRegister e configureContext, além de seus testes no commit lambda: remove old lambda invocation library?

grvcoelho commented 6 years ago

Não acha válido remover do arquivo src/resources/boleto/index.js as funções register, processBoletosToRegister e configureContext, além de seus testes no commit lambda: remove old lambda invocation library?

Boa! Removi as funções register e configureContext. A função processBoletosToRegister você vai tirar no PR #274 ,né?

evaporei commented 6 years ago

No caso o PR #274 já foi mergeado,