search

pagarme / superbowleto

:football: A microservice to issue, register and manage boletos
MIT License
5 stars 0 forks source link

bradesco: fix intermittent test date #291

Closed evaporei closed 6 years ago

evaporei commented 6 years ago

Description

The buildPayload unit test of the bradesco provider had a problem, some times the test failed and others it didn't. The issue was that the dates used on the comparison were not using the moment-timezone library, so if the test ran late on a day, it would think it is the next day and the buildPayload function which uses moment-timezone would get the correct date on the correct timezone. This commit fixes this issue by adding the timezone to the test.

Your checklist for this pull request

:rotating_light: Please review this items for a good pull request. :four_leaf_clover:

  1. I've read the project's Contributing Guidelines
  2. My commits are well written and follow pagarme/git-style-guide
  3. My changes are well covered by tests and logs
  4. I've updated the project docs (if needed)
  5. I fell safe about this implementation
  6. I feel comfortable with the code I wrote, and I'm not ashamed to show it to my friends

In a good pull request, everything above is true :relaxed: