search

pagarme / superbowleto

:football: A microservice to issue, register and manage boletos
MIT License
5 stars 0 forks source link

Add configuration option to dd-trace library #314

Closed itsdaiego closed 5 years ago

itsdaiego commented 5 years ago

Description

Add configuration options to dd-trace library, the default value for the hostname is localhost which in this case will be the Datadog agent's load balancer endpoint, the default port is also 8126, I just decided to leave it explicit within the application :)

Your checklist for this pull request

:rotating_light: Please review this items for a good pull request. :four_leaf_clover:

  1. I've read the project's Contributing Guidelines
  2. My commits are well written and follow pagarme/git-style-guide
  3. My changes are well covered by tests and logs
  4. I've updated the project docs (if needed)
  5. I fell safe about this implementation
  6. I feel comfortable with the code I wrote, and I'm not ashamed to show it to my friends

In a good pull request, everything above is true :relaxed:

evaporei commented 5 years ago

@itsdaiego gostaria de verificar se entendi o cenário atual. Hoje nada acontece pois a lib não consegue se conectar, e com esse PR e uma nova chave adicionada ao credstash, isso será possível?