search

pageauc / pi-timolo

Raspberry PI-TIMOLO ( PI-TImelapse, MOtion, LOwLight ) uses RPI picamera and OpenCV for Remote Headless Security Monitoring using Motion Tracking, Rclone Auto Sync files with remote storage services. Auto Twilight Transitions and Low Light Camera Settings. Panoramic images using PanTiltHat and More. This project is featured on GitHub Awesome software.
MIT License
548 stars 101 forks source link

IMAGE_USE_VIDEOPORT config is not used #121

Closed npaibrooklyn closed 3 years ago

npaibrooklyn commented 3 years ago

use_video_port is hardcoded to True: https://github.com/pageauc/pi-timolo/blob/master/source/pi-timolo.py#L572

Consider removing IMAGE_USE_VIDEOPORT config variable or using it

pageauc commented 3 years ago

Made change a while back and did not remove in case I wanted to revert back. There are other things in the code that probably need looking at but sometimes you create more problems when tinkering with code that is working. There are certainly areas for optimization. I normally use pylint and other tools to check code. I am aware of other issues as well. This project was originally done as a personal project that grew from two of my older projects rpi-timelapse with low light and motion tracking I combined these and it grew from there.

Just curious but seems like you are doing some detailed audit and review of my code. I normally use pylint and am aware of the miscellaneous issues like unused variables and naming issues. eg there are a mix of snake_case and caMel case.. Other projects I see also have similar issues and it is not a critical issue since this is simply a personal, shared project and not production. I am just a retired dude who codes as a hobby.

Your contributions are appreciated.. Claude ...

On Thu, Apr 29, 2021 at 2:56 AM npaibrooklyn @.***> wrote:

use_video_port is hardcoded to True: https://github.com/pageauc/pi-timolo/blob/master/source/pi-timolo.py#L572

Consider removing this config variable or using it

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pageauc/pi-timolo/issues/121, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNPKZEXREANEUKK4EZAN6LTLD7KDANCNFSM43ZHATQA .

-- YouTube Channel at https://www.youtube.com/user/pageaucp http://www.youtube.com/user/pageaucp GitHub Repository at https://github.com/pageauc

npaibrooklyn commented 3 years ago

Ah I understand now. Sorry I misunderstood it to be an active community project and I was trying to help maintain as and when I found issues.

pageauc commented 3 years ago

I have implemented your change. And I do appreciate contributions and feedback.

The video port idea was included with a push by another user. After testing I later found it was not really required so I changed code but left the config.py constant and it later got added with the config.py/ plugin constant variable check dictionary audit routine.

Was just wondering why out of 2400 odd lines of code someone would report a constant that was not being used and not creating any issue other than a user trying to use the variable and nothing significant happening. An average person would not discover this without an auditing tool. It would be like a code comment with a not critical typo.

I normally study other users code to analyse the underlying algorithm(s), copy a snippet to adapt for myself, Etc. During these reads, I often find useless or inactive logic, constants, data structures, branches Etc. Lots of projects have commented out code lines, blocks, functions, Etc that serve no real purpose other than a reminder of code history, inactive feature, Etc.. The code still runs just fine with or without these.

That is a complement to you Claude ...

On Thu, Apr 29, 2021 at 1:29 PM npaibrooklyn @.***> wrote:

Ah I understand now. Sorry I misunderstood it to be an active community project and I was trying to help maintain as and when I found issues.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pageauc/pi-timolo/issues/121#issuecomment-829452215, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNPKZBDSB54SROTDZ5OPBLTLGJRLANCNFSM43ZHATQA .

-- YouTube Channel at https://www.youtube.com/user/pageaucp http://www.youtube.com/user/pageaucp GitHub Repository at https://github.com/pageauc

npaibrooklyn commented 3 years ago

Thank you @pageauc ! I totally understand. Given I am a professional software engineer, I was in "help better the original repo and contribute and cleanup" mode haha. I really appreciate this repo - it helped me get started on my fun personal project!

pageauc commented 3 years ago

Covid Lockdown makes you appreciate human contact. You just peaked my curiosity, that is all.

Thanks for the reply and Stay Safe. Claude ...

On Thu, Apr 29, 2021 at 3:20 PM npaibrooklyn @.***> wrote:

Thank you @pageauc https://github.com/pageauc ! I totally understand. Given I am a professional software engineer, I was in "better the repo and contribute" mode haha. I really appreciate this repo - it helped me get started on my fun personal project!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pageauc/pi-timolo/issues/121#issuecomment-829522478, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNPKZHBOZHRU45MF6N6MMLTLGWQVANCNFSM43ZHATQA .

-- YouTube Channel at https://www.youtube.com/user/pageaucp http://www.youtube.com/user/pageaucp GitHub Repository at https://github.com/pageauc

npaibrooklyn commented 3 years ago

@pageauc I completely understand - hopefully covid will be conquered soon! Do you have a linkedin account - wanted to add you as a friend there

pageauc commented 3 years ago

I am retired. Just use GitHub, YouTube and Twitter. My wife uses Facebook and misc messaging apps. My US IPhone is only used for emergencies, no data, just prepaid. Besides Canadian data rates are probably the highest in the world for no other reason but limited competition and greed. I Just buy a data pack for my wife's phone when we are travelling. Regards Claude ...

On Thu, Apr 29, 2021 at 5:33 PM npaibrooklyn @.***> wrote:

@pageauc https://github.com/pageauc I completely understand - hopefully covid will be conquered soon! Do you have a linkedin account - wanted to add you as a friend there

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pageauc/pi-timolo/issues/121#issuecomment-829610553, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNPKZE3VFC3REMHNJXEWM3TLHGB7ANCNFSM43ZHATQA .

-- YouTube Channel at https://www.youtube.com/user/pageaucp http://www.youtube.com/user/pageaucp GitHub Repository at https://github.com/pageauc