RandallKent
commented
2 years ago @mlapaglia - Whoops! Recently got a M1 Mac and didn't think of it. Just rebuilt the image for multiple platforms.
Closed RandallKent closed 2 years ago
RandallKent
commented
2 years ago @mlapaglia - Whoops! Recently got a M1 Mac and didn't think of it. Just rebuilt the image for multiple platforms.
pageauc
commented
2 years ago Randall
I finally upgraded my Texas PC to Windows 10 and was looking to test docker install for speed-camera. Noticed in the Dockerfile on github still showing Gnuplot instead of matplotlib so I updated the file and pushed to repo. I am guessing your intention is to just use python3 for docker. I agree with this. If that is the case then the webserver3.py should be used instead of webserver.py or webserver3.py copied over webserver.py. Also not sure if menubox.sh can be run from the docker. This is a whiptail menu system.
Also do you have an email address or way to communicate via speed camera repo other than using a previous issue to communicate. Thanks Claude ... Claude ...
RandallKent
commented
2 years ago Hey @pageauc -
When I initially got the Docker image up and running and when I bumped the version in the image on dockerhub, I did not do an incredibly deep analysis of speed camera's source nor any optimizations on the Docker image. There are likely several things that can/should be done to improve performance and ensure things are running as you expect them to.
For collaborating I'd love to do as much of it in public as possible so the rest of the speed camera community can jump in and help. To do this, I'd suggest creating GitHub Issues for each of the area's you'd like to dig into. For example:
Each issue will provide a space for discussion. When code changes are necessary, Pull requests can be made. Some guidelines for Pull Requests inspired by Cypress' Contributing doc...
For more real-time communication, Discord seems to be a popular choice these days. I've created a Discord Server for Speed Camera which can be joined via https://discord.gg/dGPUWK8b
-Randall
pageauc
commented
2 years ago Thanks Randall
I guess I will get a docker image working so I can get some experience. matplotlib is already implemented and sql-make-graph-speed-ave.py and sql-make-graph-count-totals.py scripts can be used to generate graphs (per command line parameters or via config.py matplotlib section settings.. Graphs can be viewed in the webserver per config.py GRAPH_PATH variable..
I have added a rough wiki here https://github.com/pageauc/speed-camera/wiki/How-to-Generate-Speed-Camera-Graphs
Claude ...
On Tue, Jan 4, 2022 at 1:26 PM Randall Kent @.***> wrote:
Hey @pageauc https://github.com/pageauc -
When I initially got the Docker image up and running and when I bumped the version in the image on dockerhub, I did not do an incredibly deep analysis of speed camera's source nor any optimizations on the Docker image. There are likely several things that can/should be done to improve performance and ensure things are running as you expect them to.
For collaborating I'd love to do as much of it in public as possible so the rest of the speed camera community can jump in and help. To do this, I'd suggest creating GitHub Issues https://github.com/pageauc/speed-camera/issues/new/choose for each of the area's you'd like to dig into. For example:
- "Use matplotlib instead of Gnuplot in Docker Image"
- "Ensure Docker Image uses python3 consistently"
- "Evaluate necessity of whiptail menu system in Docker Image"
Each issue will provide a space for discussion. When code changes are necessary, Pull requests can be made. Some guidelines for Pull Requests inspired by Cypress' Contributing doc https://github.com/cypress-io/cypress/blob/develop/CONTRIBUTING.md#pull-requests ...
- Break down pull requests into the smallest necessary parts to address the original issue or feature. This helps you get a timely review and helps the reviewer clearly understand which pieces of the code changes are relevant.
- When opening a PR for a specific issue already open, please name the branch you are working on using the convention issue-[issue number]. For example, if your PR fixes Issue #803, name your branch issue-803. If the PR is a larger issue, you can add more context like issue-803-new-scrollable-area. If there's not an associated open issue, create an issue https://github.com/pageauc/speed-camera/issues/new/choose.
- PR's can be opened before all the work is finished. In fact we encourage this! Please create a Draft Pull Request https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests#draft-pull-requests if your PR is not ready for review. Mark the PR as Ready for Review https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-stage-of-a-pull-request#marking-a-pull-request-as-ready-for-review when you're ready for a team member to review the PR.
- Prefix the title of the Pull Request using semantic-release's format as defined here. For example, if your PR is fixing a bug, you should prefix the PR title with fix:.
- Please check the "Allow edits from maintainers" checkbox when submitting your PR. This will make it easier for the maintainers to make minor adjustments, to help with tests or any other changes we may need.
- After the PR is approved, the original contributor can merge the PR (if the original contributor has access).
- When you merge a PR into develop, select Squash and merge https://docs.github.com/en/github/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-pull-request-commits. This will squash all commits into a single commit.
For more real-time communication, Discord seems to be a popular choice these days. I've created a Discord Server for Speed Camera which can be joined via https://discord.gg/dGPUWK8b
-Randall
— Reply to this email directly, view it on GitHub https://github.com/pageauc/speed-camera/pull/108#issuecomment-1005106458, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNPKZER3R6LZX4EWOLKB2DUUNCUZANCNFSM5LAQNRCQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
-- YouTube Channel at https://www.youtube.com/user/pageaucp http://www.youtube.com/user/pageaucp GitHub Repository at https://github.com/pageauc
this appears to have built an arm64 version of the code? can it also build amd64 so i can use it? https://hub.docker.com/r/randallkent/speed-camera/tags