pagedjs / pagedjs

Display paginated content in the browser and generate print books using web technology
https://pagedjs.org
MIT License
842 stars 88 forks source link

Improper footnote counter generated #59

Open zopyx opened 2 years ago

zopyx commented 2 years ago

The footnotes have both the counter 2

https://github.com/zopyx/print-css-rocks/tree/master/lessons/lesson-footnotes

Bildschirmfoto 2022-03-01 um 19 01 24
julientaq commented 2 years ago

Thanks for opening the issue!

jcuenod commented 2 years ago

I had the same issue. Removing this resolves it:

::footnote-marker {
    content: counter(footnote, loweralpha) ". ";
}

But that is what is suggested in the release notes announcing footnote support

julientaq commented 2 years ago

yes, it’s a bug we need to figure out what happens here.

julientaq commented 2 years ago

Spent some time on it, and for unknow reason i manage to make it work by callng another counter:

index.html.zip

.footnote::footnote-marker {
    content: counter(footnote-marker, lower-roman);
    font-size: 14pt;
    color: blue;
}

counter foonote-marker works while footnote footnote doesn’t so i assume there is something wrong if how it does the calculation, as the note number is always the maximum amount of note there is on a page.

julientaq commented 2 years ago

@fchasen you may want to have a look!