search

pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
4.34k stars 1.74k forks source link

bug, Damp activation feedback messages #1476

Open RNGezeus opened 3 months ago

RNGezeus commented 3 months ago

So while damp did in fact cancel them, this minior tried using 5 suicide moves on its turn, not even just the same move but both Selfdestruct and Explosion.

Edit: The weirder part is that 4 of them happen with priority higher than pokeballs as well, last one after is probably legit

https://github.com/pagefaultgames/pokerogue/assets/46976469/2eb78c82-302b-42b1-9587-cd871b08e294

zacharied commented 3 months ago

There's definitely a bug involving Damp using these overrides:

export const OPP_MOVESET_OVERRIDE: Array<Moves> = [Moves.SELF_DESTRUCT, Moves.SELF_DESTRUCT, Moves.EXPLOSION, Moves.EXPLOSION];
export const ABILITY_OVERRIDE: Abilities = Abilities.DAMP;

https://github.com/pagefaultgames/pokerogue/assets/6374275/9f481456-0e5b-419d-8d2d-671ed4e93a37

I'm pretty sure this is an issue with Damp not checking to see if the usage is simulated or not. So, when an AI goes to calculate the damage that would be dealt against an opponent with Damp, it triggers the activation message.

Not sure if that's the same as what's going on in the OP, but it's certainly bugged.

zacharied commented 2 months ago

I've been in the trenches of Damp's impl for quite a few hours now and I'm 99% sure that my last comment also describes the issue in OP.

Snailman11 commented 2 weeks ago

Link to Discord's bug report (Damp triggers if the opponent HAS a self-destruct move even if it does not use it) https://discord.com/channels/1125469663833370665/1242203040216514660