search

pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
4.4k stars 1.78k forks source link

Supercell Slam's Line 63994 in tms.ts is missing a space towards the end. #1528

Closed H-A-R-V closed 2 months ago

H-A-R-V commented 4 months ago

https://github.com/pagefaultgames/pokerogue/blob/0780211901c2cfa67f5eb1735f3446a68d45dcf4/src/data/tms.ts

Line 63994

" [Moves.SUPERCELL_SLAM]:["

to

" [Moves.SUPERCELL_SLAM]: ["

JakubHanko commented 4 months ago

Quite possibly solved with the addition of this rule to the linter?

https://eslint.style/rules/js/key-spacing

H-A-R-V commented 4 months ago

Does this mean adding a space wouldn't fix it? I just noticed it was inconsistent with the other TM's when I went to pull data for the wiki.

JakubHanko commented 4 months ago

It definitely would fix it. However, I think it would be great if this was caught by the linter instead of a human.

God knows how many similar errors are there.

Tempo-anon commented 2 months ago

Going to close this issue out since we have lots of linting improvements that can be done