search

pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
4.27k stars 1.7k forks source link

[BUG] Fusions incorrectly showing ability as hidden #1766

Open Terrorforge opened 2 months ago

Terrorforge commented 2 months ago

Describe the bug

When the "head" of a fusion has a hidden ability, the ability of the fusion shows up in the yellow "this is a hidden ability" font on the catch screen, even though the ability in question is usually one of the "body"'s non-hidden abilities.

To Reproduce

  1. Catch a fusion where the head has a hidden ability but the body does not.

Expected behavior

To be honest I'm not sure what the best way to display this is, but the current situation feels very strange.

Screenshots / Videos

image The Absol in this Absol/Oranguru fusion has its hidden ability, Justified. The fused form uses the Oranguru's non-hidden Inner Focus ability, but it displays as a hidden ability because of Justified.

Device

Chrome on PC.

Additional context

RNGezeus commented 2 months ago

Given that catching these mons does unlock the hidden ability for the base it makes sense that it should be shown with darkened ball(if not already owned) and the yellow notation in catch summary.

It would lead to an even stranger situation if a you caught one of these mons with darkened ball from HA, the new summary screen showing the ability is new but the text not being noted as the HA.

Terrorforge commented 2 months ago

I think I would've found that easier to understand. If it said I had a new ability but didn't show a new ability, I would assume I'd unlocked something from the other pokemon. Mixing them like this made me very confused about which pokemon I'd unlocked something for.

Regardless, both options suck. The correct solution would be a different display altogether. Would be nice if you could see both abilities up front for unfusing purposes, but then people would assume it has both. So a little yellow (+H) next to the ability or something?