search

pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
4.41k stars 1.78k forks source link

[BUG] Egg moves do not save #1932

Closed HyperRes closed 2 months ago

HyperRes commented 3 months ago

Changing egg moves before adding the mon to the party will not save the egg moves. This will save the egg moves in the starter screen for any next runs, but not the current run if you start it. Once you have edited the mons move set and you add it to the party changing any egg moves will have no effect and the mon will start with whatever move set it had prior to opening the starter screen.

flx-sta commented 3 months ago

@HyperRes Would you mind showing a video of the exact procedure ?

RNGezeus commented 3 months ago

I Presume this is what he meant.

https://github.com/pagefaultgames/pokerogue/assets/46976469/5728afda-34b9-4ba0-89c8-0732fdc83c30

HyperRes commented 3 months ago

@HyperRes Would you mind showing a video of the exact procedure ?

What @RNGezeus posted is exactly what I meant. I can consistently recreate it every time if you want more video.

gjeodnd12165 commented 3 months ago

Seeing the codes, addToParty adds the copy of the moveset while selectMoveSwapWith modify the origial moveset.

I'm trying to fix it, but I don't come up with some simple solution that doesn't change structure of StarterMovesets.

RNGezeus commented 3 months ago

Seeing the codes, addToParty adds the copy of the moveset while selectMoveSwapWith modify the origial moveset.

I'm trying to fix it, but I don't come up with some simple solution that doesn't change structure of StarterMovesets.

How hard / intense is it to query if users party contains the chosen pokemon after manage moves menu closes, and if it does contain them then call remove from party -> add to party?