search

pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
4.24k stars 1.68k forks source link

[Feature] add a code formatter (please!) #2069

Closed flx-sta closed 3 weeks ago

flx-sta commented 2 months ago

Is your feature request related to a problem? Please describe.

It’s quite frustrating and tedious to stay on par with the existing code formatting as there is no standardized way to format the code

Describe the Feature

Can we please add an opinionated code formatter like prettier ?

I know there is people out there that might not be happy with the formatting it will dictate but thats always going to be the case with a project of this size. There is a lot of noise in PRs here and there because of formatting going back and forth.

Additional context

HighMans commented 2 months ago

Agreed, this PR for example with the imports.

https://github.com/pagefaultgames/pokerogue/pull/2057/files

Greenlamp2 commented 2 months ago

I agree. You can create a PR with what you think would fit best for this issue

flx-sta commented 2 months ago

I agree. You can create a PR with what you think would fit best for this issue

I've created a draft with a minimal change to have a look at it first https://github.com/pagefaultgames/pokerogue/pull/2101