search

pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
4.41k stars 1.78k forks source link

[Feature] Change/Remove breeders in certain biomes #2495

Closed walt253 closed 2 months ago

walt253 commented 3 months ago

Is your feature request related to a problem? Please describe. Breeders appearing on certain biomes make no sense. I noticed the breeders seem to be able to spawn in any biome. Here is a list of biomes where I think this makes no sense.

Nonsense at all Sea&Seabed: They have their clothes on. Space: How did they get there? Maybe give them a spacesuit.

Probably shouldn't be here Abyss/Desert/Factory/Laboratory/Power Plant/Slum/Wasteland: Doesn't seem a good place to breed mons. Cave/Fairy Cave/Ice Cave/Volcano: Why would they show up in caves? Also in Volcano it's maybe too hot for breeding. Dojo: Maybe have a Dojo breeder instead. Graveyard: Not sure breeding with graves around is a good idea.

Describe the Feature Either remove them from biomes where they don't make sense, OR change their sprite for those biomes.

Tempo-anon commented 3 months ago

Right now breeders are supposed to show up in plains, grass, tall grass, metropolis, beach, lake, meadow, and fairy cave. HOWEVER, in the randomTrainerType function of arena.ts the game will automatically default to a breeder if the specified biome does not have any trainers for that tier.

Tempo-anon commented 3 months ago

The real reason is because no biome has a 0% of trainer spawns

Tempo-anon commented 3 months ago

Correction: there are a few biomes that use the 0 value like lab and end so this is just a gameplay/balance/design question

Tempo-anon commented 2 months ago

Seems this is less likely now that someone has added breeders in space into the splash messages