search

pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
4.11k stars 1.64k forks source link

[BUG][modifier-select-ui-handler] Position of cursor is hard-coded so it's hard to localize #2620

Closed EnochG1 closed 38 minutes ago

EnochG1 commented 4 weeks ago

Describe the bug Translation team are trying to localize modifier-select-ui-handler texts. https://github.com/pagefaultgames/pokerogue/pull/2527

But there's issue because some of positions(x,y) are hard-coded. So if it's not English, cursor and label texts look weird. image image

It seems to calculate coordinates of cursor, not as concrete value. I would like to ask for the help of an expert on the screen rather than make issue by adjusting the cursor position myself.

To Reproduce

  1. Change label of 'transfer', 'check team' in modifier-select-ui-handler.ts
  2. Run game in test mode and check position of cursor.

Expected behavior If it's not English or not same as original label, cursor and label texts look weird.

Screenshots / Videos image

Device Chrome. (But it doesn't matter)

Additional context CC : @Adri1

Adri1 commented 3 weeks ago

Problem solved directly in PR #2527