search

pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
4.1k stars 1.64k forks source link

[BUG] Ceaseless Edge does not set up multiple layers of spikes with Multi Lens #2671

Open Terrorforge opened 3 weeks ago

Terrorforge commented 3 weeks ago

Describe the bug

Gave my Toxapex with Ceaseless Edge Multi Lens thinking it would be cool to set up two layers of spikes at a time. However, while the attack now goes off twice, only one layer of spikes is set.

To Reproduce

  1. Give a pokemon Ceaseless Edge and a Multi Lens
  2. Use Ceaseless Edge

Expected behavior

When a move is executed twice, its secondary effects should also happen twice, as happens with e.g. Power-Up Punch.

Screenshots / Videos

image image It should not even be possible for my Toxapex to only have one layer of spikes up.

Device

Chrome on PC

schmidtc1 commented 3 weeks ago

I believe this is due to the parent class having firstHitOnly as true when calling super: https://github.com/pagefaultgames/pokerogue/blob/67a21b8a9496af739e14ca60954244891fc7fffe/src/data/move.ts#L4203

schmidtc1 commented 3 weeks ago

I believe this is due to the parent class having firstHitOnly as true when calling super:

https://github.com/pagefaultgames/pokerogue/blob/67a21b8a9496af739e14ca60954244891fc7fffe/src/data/move.ts#L4203

Testing with it as false doesn't seem to affect Reflect/Stealth Rock/other trap moves

torranx commented 3 weeks ago

is this confirmed to be not a UI issue only? i mean the flyout is maybe only showing inaccurate number

Terrorforge commented 3 weeks ago

Not confirmed either way, no. I did only get the "spikes were scattered" message once, after the first hit, but that could also be a UI issue.

schmidtc1 commented 3 weeks ago

Seeing as setting 'firstHitOnly' to false solves the issue, I feel as though it's not a UI issue.