pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
4.41k stars 1.78k forks source link

[BUG] - Double single battle #2814

Closed OriShalhon closed 2 months ago

OriShalhon commented 3 months ago

After fainting own pokemon in double battle - it turns a single battle into double and the game freezes

To Reproduce

  1. Enter double battle
  2. have a faster pokemon attack the enemy and a slower pokemon attack a field-wide attack (everyone)
  3. win the fight during the first attack, the 2nd attack from the slower pokemon kills the first pokemon
  4. on next fight, the game prompts to add another pokemon to the field

The result is a single battle with two pokemons on the field and the game frozen

Expected behavior When choosing the first pokemon after fainting it should be entered into a single battle

Screenshots image

Device running on Chromium browser (Brave)

Additional context In Console of Errors - it infinitely returns error: Texture X has no Frame Y

DustinLin commented 3 months ago

can you post a video? i tried following your instructions and can't reproduce the problem:

https://github.com/pagefaultgames/pokerogue/assets/39450497/ed121f3f-0b01-495e-a8ca-b464e4667ff9

OriShalhon commented 3 months ago

It was a pretty specific turn of event, To be more specific, It was a double battle right before a boss, and the first Pokémon fainted after beating the enemy Pokémon in the fight by an attack of the 2nd Pokémon (I assume the order matters is the first one is supposed to stay for the next fight)

On Sat, Jul 6, 2024, 19:52 DustinLin @.***> wrote:

can you post a video? i tried following your instructions and can't reproduce the problem:

https://github.com/pagefaultgames/pokerogue/assets/39450497/ed121f3f-0b01-495e-a8ca-b464e4667ff9

— Reply to this email directly, view it on GitHub https://github.com/pagefaultgames/pokerogue/issues/2814#issuecomment-2211831731, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHFIFZPZLC3CRTBOP2ZMN43ZLAVETAVCNFSM6AAAAABKNOJFY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRHAZTCNZTGE . You are receiving this because you authored the thread.Message ID: @.***>

OriShalhon commented 2 months ago

@DustinLin looking at your video - its not the bug causing scenario

  1. The first Pokémon (in your video Wailmer) attacks the enemy with an attack that faints the enemy team
  2. the second Pokémon ( in your video Charmander) attacks a battle-wide attack killing the first Pokémon (Wailmer)

what happens -

  1. the enemy Pokémon die from first attack
  2. with no enemy Pokémon left, the 2nd attack kills your own Pokémon
  3. bug should recreate after choosing Pokémon to replace fainted one
flx-sta commented 2 months ago

Duplicate of #222