search

pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
4.44k stars 1.79k forks source link

[BUG] Healing Wish bug #2994

Open holohok opened 3 months ago

holohok commented 3 months ago

Describe the bug I used healing wish and switched in a full health Pokémon, but the wish still “activated” and did nothing

To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior When you swap a full health Pokémon in after using healing wish, the wish should be stored until you swap to a weakened Pokémon

Screenshots / Videos

Device pc

Additional context I used the wish as chimecho and swapped into Milotic if that matters

keep up the good work this game is killer

mucho7 commented 3 months ago

I am interested in this issue and am currently looking into it. I have a few questions, and I would appreciate any responses.

  1. How about adding a HealingWishTag to ArenaTag to accurately follow the mechanism of Healing Wish? This way, we can run a check to determine if the user's Pokémon has max HP every time it is switched in.

  2. It seems that some of the texts in src/data/moves have not been internationalized yet. If there is no specific reason, how about proceeding with the internationalization of at least the Healing Wish part?

DayKev commented 2 months ago

1: I haven't touched the ArenaTags part of the code much but that sounds fine to me. 2: Adding i18n is always appreciated.