pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
4.53k stars 1.81k forks source link

[BUG] Abilities That Use PostSummonAbAttr Do Not Apply Summoned Abilities if the Player Initially Agrees to Switch. Abilities Include: Imposter, Hadron Engine, Primordial Sea, Download, Schooling, Drizzle, #3482

Open Snailman11 opened 3 months ago

Snailman11 commented 3 months ago

Describe the bug

Abilities with that attribute do not apply their abilities when they should if the player initially agrees to switch, then declines when the party screen appears.

Reproduce by Starting with at least two Pokémon with either having an ability that uses PostSummonAbAttr, Press the Yes option, then press X/back.

[Tera Shift is included]

https://discord.com/channels/1125469663833370665/1263401058223390753 This Bug as reported on Discord.

User data export file

No response

Session export file

No response

Expected behavior

I expect the ability to be applied if the player backs out of switching.

Screenshots / Videos

https://github.com/user-attachments/assets/786948c3-2d44-41a7-be02-318cf35c4b14

Screenshot (241) Screenshot (242)

What OS did you observe the bug on?

PC/Windows

If other please specify

gameplay

Which browser do you use?

Other

If other please specify

gameplay

Additional context

Currently Skill Swap does not reapply some swapped abilities. Changing how it works here might fix that. https://discord.com/channels/1125469663833370665/1261931153959686165

Sometimes PostSummonAbAttr abilities sometimes fail to redeploy on reload (Summoning abilities don't activate when reloading a session) https://github.com/pagefaultgames/pokerogue/issues/1005

Snailman11 commented 3 months ago

Hadron Engine, also mentions reload https://github.com/pagefaultgames/pokerogue/issues/1688 (Hadron Engine does not activate if you exit out of switch menu)

PigeonBar commented 1 month ago

Updating this to include Forecast: https://discord.com/channels/1125469663833370665/1126338176659763210/threads/1289916179627905105