[Question] About failCatch shake count

pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.

https://pokerogue.net

GNU Affero General Public License v3.0

4.34k stars 1.74k forks source link

[Question] About failCatch shake count #3486

Open SYChoi opened 1 month ago

SYChoi commented 1 month ago

I think this could be my skill issue, but I'm taking the liberty of asking questions.

Is there any reason to provide shake count to failCatch method in AttemptCapturePhase class? ShakeCount never used in failCatch method neither update.

innerthunder commented 1 month ago

I believe it was originally meant for a future implementation of "failed catch" messages. The mainline games show different messages based on how many times the ball shakes before the Pokemon breaks free.

SYChoi commented 1 month ago

I see. Then, is there any plan to change the message now? or just a legacy it is?

innerthunder commented 1 month ago

I don't think anyone's actively working on it at the moment, so if you want to make a PR on it, feel free 😄