search

pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
4.36k stars 1.74k forks source link

[Bug] Skill Swap, Role Play, Entrainment, Trace, and Neutralizing Gas(P) Do not Reactivate abilities when Gaining them or After Suppression Wears off #3905

Open Snailman11 opened 2 weeks ago

Snailman11 commented 2 weeks ago

Describe the bug

The above abilities and moves don't "activate" abilities when they should, ex. Intimidate, Download

Session export file

No response

User data export file

No response

Expected behavior

(1a, 2, 4) https://replay.pokemonshowdown.com/gen9customgame-2190559634-saoooyiccf7ranxqatw26ueli22pn57pw (1b) https://replay.pokemonshowdown.com/gen9customgame-2190582913-oc7pvy340gfps3t9w92gzsa3kafwgozpw (3) https://replay.pokemonshowdown.com/gen9customgame-2190602831-7cpl0g8xo9bw72mk1t1aekva8o8iht5pw

1a. Trace activates an ability when copying it. 1b. Trace waits for a copiable ability to enter the field on the opposing side and copies it.

  1. Skill Swap "activates" both abilities.
  2. Role Play and Entrainment activate gained abilities, (fails if the ability are the same - Implemented)
  3. Neutralizing Gas leaving the field "activates" the ability.

1a. While a Pokémon with Trace is in battle, if at any time an opponent has an Ability that can be copied by Trace, Trace will activate and replace itself with that Ability. (Doesn't actually explicitly mention that the new ability gets activated, but it does)

1b. While a Pokémon with Trace is in battle, if at any time an adjacent opponent has an Ability that can be copied by Trace, Trace will activate and replace itself with that Ability.

  1. If both Pokémon have the same Ability, Skill Swap will succeed. If it is an Ability such as Intimidate that activates when it is gained, it will activate for both Pokémon after being gained this way.

  2. Once Neutralizing Gas is no longer applying, Abilities that activate when gained (i.e. Abilities that activate when a Pokémon is switched in, such as Intimidate) immediately pop up an activation message regardless of whether they have already done so, with the exceptions of Unnerve (which still applies but without displaying a message) and Imposter (which only activates when switched in, not when gained). If Neutralizing Gas stops applying because the Pokémon with Neutralizing Gas is about to switch out, those Abilities activate before the switch occurs (e.g. if Intimidate is activated this way, it will decrease the Attack of the Pokémon with Neutralizing Gas before it switches out, rather than decreasing the Attack of the Pokémon who switches in to replace it).

Screenshots / Videos

Trace (Intimidate)

https://github.com/user-attachments/assets/e7ccffc8-b31b-49b7-b96c-4b4e383557f4

Skill Swap (Intimidate and Download)

https://github.com/user-attachments/assets/59b845a3-ba15-4e06-92db-a563af157592

Role Play (Intimidate)

https://github.com/user-attachments/assets/b30244ba-fc0f-4aaa-8914-0ce7c5f0d9bb

Entrainment (Download)

https://github.com/user-attachments/assets/e3ffe1c9-44e6-4ef0-8aa2-46764b622d55

Neutralizing Gas (Intimidate)

https://github.com/user-attachments/assets/f387dded-3c91-4e49-b91a-36c961ead9f8

(Delta Stream does not reactivate)

https://github.com/user-attachments/assets/f3ec8241-d96c-4885-b0bc-aa82b4cbf695

Neut. Gas into Neut. Gas (Ability should apply as Neut gas switches out)

https://github.com/user-attachments/assets/5a3dfcc0-3cac-4d40-954a-1dfcc9662725

What OS did you observe the bug on?

Other

If other please specify

gameplay

Which browser do you use?

Other

If other please specify

gameplay

Additional context

No response

Snailman11 commented 2 weeks ago

Link to Discord's Bug reports (Regigigas Skill Swap) https://discord.com/channels/1125469663833370665/1261931153959686165

(Tracing intimidate doesn't work) https://discord.com/channels/1125469663833370665/1240031914052550778

Snailman11 commented 2 weeks ago

Truant and Innards Out (#1263) Don't get swapped properly by Skill Swap and Trace https://discord.com/channels/1125469663833370665/1261931153959686165/1271178864307081277 -They do not become active on the mon that gains them.

Snailman11 commented 3 days ago

Flower Gift is not Reactivated (changing form to sunny/overcast) once Neutralizing Gas has left the field https://discord.com/channels/1125469663833370665/1284271625650311249